Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move wrap to be method _expose() #235

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 14, 2023

Make wrap() function a method _expose()

Checklist

@Uzlopak Uzlopak requested review from metcoder95 and mcollina August 14, 2023 18:36
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Possibly it might be better to move this into its separate file and keep it a function. Boot has a already too many responsibilities.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 15, 2023

I plan to reduce the complexity of boot. Here the original wrap function makes much more sense, to be part of boot class, as it is 99% about boot and the modification of the underlying server with methods of boot.

@Uzlopak Uzlopak merged commit 9da3798 into master Aug 15, 2023
@Uzlopak Uzlopak deleted the rename-wrap-to-expose branch August 15, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants