Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw AVV_ERR_CALLBACK_NOT_FN in onClose instead of generic Error #239

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: throw AVV_ERR_CALLBACK_NOT_FN in onClose instead of generic Error #239

merged 2 commits into from
Aug 15, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 15, 2023

Checklist

@Uzlopak Uzlopak requested review from kibertoad and Fdawgs August 15, 2023 16:11
@Fdawgs
Copy link
Member

Fdawgs commented Aug 15, 2023

What is this fixing, is there an associated issue, or is it more of a refactor?

mcollina
mcollina approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 15, 2023

@Fdawgs

Refactoring avvio till it is 100% test coverage etc.

@Uzlopak Uzlopak merged commit c3b50ef into master Aug 15, 2023
@Uzlopak Uzlopak deleted the various branch August 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @Fdawgs @mcollina