Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use options as function type #248

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

MatteoGranziera
Copy link
Contributor

This change correct the type of options argument of the use function following this line of code

this.options = typeof this.options === 'function' ? this.options(this.server) : this.options

Checklist

Note: tests on my local machine returns a lot of errors but I didn't get the problem, hope it's work in CI

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 5, 2024

Yeah well,with failing tests we can not merge it.

@MatteoGranziera
Copy link
Contributor Author

MatteoGranziera commented Feb 5, 2024

@Uzlopak yes of course, any help for the tests?
Doesn't work using master either, could be tap version problem?

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 5, 2024

Master is broken?
Will have a look shortly

@mcollina
Copy link
Member

mcollina commented Feb 5, 2024

Seems like it, updating the dependencies in my local branch breaks it.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit e36b7ef into fastify:master Feb 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants