Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout count for nested plugins #254

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix timeout count for nested plugins #254

merged 2 commits into from
May 21, 2024

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented May 20, 2024 •
edited
Loading

This PR changes avvio to make the error message indicate the correct plugin that timed out.

Checklist

@mcollina
Fix timeout count for nested plugins
e5f4c52 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
986530d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Uzlopak
Uzlopak approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ivan-tymoshenko
ivan-tymoshenko approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday
gurgunday approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 9c895a1 into master May 21, 2024
19 checks passed
@Uzlopak Uzlopak deleted the fix-timeout-count-for-nested-plugins branch May 21, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@ivan-tymoshenko ivan-tymoshenko ivan-tymoshenko approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@jsumners jsumners jsumners approved these changes

@davidmarkclements davidmarkclements Awaiting requested review from davidmarkclements

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcollina @jsumners @Uzlopak @ivan-tymoshenko @gurgunday