Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: updates to run with node 22 #255

Merged
merged 3 commits into from
May 20, 2024
Merged

ci: updates to run with node 22 #255

merged 3 commits into from
May 20, 2024

Conversation

big-kahuna-burger
Copy link
Contributor

@big-kahuna-burger big-kahuna-burger commented May 20, 2024 •
edited
Loading

Checklist

@gurgunday
Copy link
Member

Please see the next branch

@big-kahuna-burger
Copy link
Contributor Author

big-kahuna-burger commented May 20, 2024 •
edited
Loading

I see. So... change base to next and pin to 4.2.1?

mcollina
mcollina requested changes May 20, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f17dd00 into fastify:master May 20, 2024
17 checks passed
@big-kahuna-burger big-kahuna-burger deleted the latest-node-ci branch May 21, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@big-kahuna-burger @gurgunday @mcollina