Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for expose "close" and "onClose" #256

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix typings for expose "close" and "onClose" #256

merged 1 commit into from
May 28, 2024

Conversation

MatteoGranziera
Copy link
Contributor

@MatteoGranziera MatteoGranziera commented May 28, 2024 •
edited
Loading

This PR correct the "expose" config typing by adding "close" and "onClose" options

Checklist

@MatteoGranziera
Copy link
Contributor Author

MatteoGranziera commented May 28, 2024 •
edited
Loading

Failed tests are not related to this PR, should be handled in another PR?

@climba03003
Copy link
Member

Failed tests are not related to this PR, should be handled in another PR?

Yes

mcollina
mcollina approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ea6c932 into fastify:master May 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@climba03003 climba03003 climba03003 approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatteoGranziera @climba03003 @mcollina @gurgunday