fix: expose timeout typing #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sure, I didn't notice type-related tests! |
nickfla1
force-pushed
the
fix/timeout-typing
branch
from
c1dc647 to
18413b3
Compare
nickfla1
commented
Aug 9, 2024
| @@ -386,7 +386,8 @@ import * as avvio from "../../"; | |||
| const server = { hello: "world" }; | |||
| const options = { | |||
| autostart: false, | |||
| expose: { after: "after", ready: "ready", use: "use", close: "close", onClose : "onClose" } | |||
| expose: { after: "after", ready: "ready", use: "use", close: "close", onClose : "onClose" }, | |||
| timeout: 50000 | |||
There was a problem hiding this comment.
I think this should enough, and the right place, to test this change
Eomm
approved these changes
Aug 10, 2024
Eomm
pushed a commit
that referenced
this pull request
Aug 10, 2024
Eomm
added a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
avvio.Optionstypings to include the (optional)timeoutfield, documented here.Checklist
npm run testandnpm run benchmarkand the Code of conduct