Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use(array) form #42

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Remove use(array) form #42

merged 2 commits into from
Jan 9, 2018

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 9, 2018 •
edited
Loading

@mcollina mcollina requested a review from delvedor January 9, 2018 16:15
@allevo
Copy link
Member

allevo commented Jan 9, 2018

Can we throw an error if an array is supplied?

jsumners
jsumners approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I guess we should release another breaking change.

@delvedor
Copy link
Member

delvedor commented Jan 9, 2018

Please update also the docs.

@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2018

@allevo We are already throwing.

I plan to release this as 5.0.1.

allevo
allevo approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 9675b6f into master Jan 9, 2018
@mcollina mcollina deleted the remove-array branch January 9, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@allevo allevo allevo approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcollina @allevo @delvedor @jsumners