Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root is an exception and must not have a timeout. #73

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Root is an exception and must not have a timeout. #73

merged 1 commit into from
Aug 28, 2018

Conversation

mcollina
Copy link
Member

No description provided.

@mcollina mcollina requested a review from delvedor August 28, 2018 13:58
delvedor
delvedor approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 8e80644 into master Aug 28, 2018
@mcollina mcollina deleted the root-cannot-have-a-timeout branch August 28, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @delvedor