Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update benchmark-compare and github action #165

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Mar 27, 2021

I was trying to test changes in #163 in my fork, it seemes benchmark-compare is stalled and not working and containes lots of duplicate logic. So I tried to rewrite and improve it. Also updated github action accordingly to use node LTS, new compare -u script to update readme and github-actions-x/commit to simplify commit and push step. Tried action and script in my fork with a subset of benchmarks/.

Note: Percentage flavor is removed since wasn't sure this PR and that feature is still wanted or not

Checklist

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and seems to work. But, I'll wait for another approval from the team since I didn't work in this repo for a while.

@RafaelGSS RafaelGSS requested a review from a team March 29, 2021 00:50
@mcollina
Copy link
Member

go ahead and land @RafaelGSS, I won't have time to review. If it works locally for you it's good.

@RafaelGSS
Copy link
Member

Thanks @pi0!

@RafaelGSS RafaelGSS merged commit 9bd6190 into fastify:master Mar 29, 2021
@pi0 pi0 deleted the update-scripts branch March 30, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants