chore: migrate from tap to node:test and c8 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancastillo
commented
Oct 22, 2024
| @@ -27,18 +27,18 @@ | |||
| "lint:everything": "npm run lint && npm run test:types", | |||
| "lint:fix": "standard --fix", | |||
| "lint:standard": "standard --verbose | snazzy", | |||
| "test:mocha": "tap", | |||
| "test:unit": "c8 --statements 98 --branches 97 --functions 96 --lines 98 node --test", | |||
There was a problem hiding this comment.
cannot do c8 ---100 since there is not already 100% coverage being tracked here #126
There was a problem hiding this comment.
nice! I didn't know we could separate them
gurgunday
approved these changes
Oct 22, 2024
|
@gurgunday do you have permission to merge this if its good to go? I dont have permission on this repo |
gurgunday
approved these changes
Oct 30, 2024
| @@ -27,18 +27,18 @@ | |||
| "lint:everything": "npm run lint && npm run test:types", | |||
| "lint:fix": "standard --fix", | |||
| "lint:standard": "standard --verbose | snazzy", | |||
| "test:mocha": "tap", | |||
| "test:unit": "c8 --statements 98 --branches 97 --functions 96 --lines 98 node --test", | |||
There was a problem hiding this comment.
nice! I didn't know we could separate them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct