Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated workflows #177

Merged
merged 2 commits into from
Nov 28, 2024
Merged

remove outdated workflows #177

merged 2 commits into from
Nov 28, 2024

Conversation

gurgunday
Copy link
Member

These jobs are done by the centralized workflow

@gurgunday gurgunday changed the title remove outdated CI remove outdated workflows Nov 28, 2024
@gurgunday gurgunday requested review from Fdawgs and a team November 28, 2024 11:14
@Fdawgs
Copy link
Member

Fdawgs commented Nov 28, 2024

The coverage badge will need removed from the readme if the coverage workflow is going.

@gurgunday
Copy link
Member Author

gurgunday commented Nov 28, 2024

It was trying to use nyc, should I instead change it to use c8? Don't know if it would still work though

@Fdawgs
Copy link
Member

Fdawgs commented Nov 28, 2024

It was trying to use nyc, should I instead change it to use c8? Don't know if it would still work though

Changing the reporter wouldn't work. The coverage badge points to coveralls, which recieves an lcov report from that coverage workflow. We'd need to update the shared workflow to support coverage reporting but... meh.

The test:unit script enforces coverage, so just get rid of the badge. :)

@gurgunday gurgunday merged commit 5f47d13 into master Nov 28, 2024
13 checks passed
@gurgunday gurgunday deleted the coverage branch November 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants