Handle items: [{ $ref }] #734
Conversation
Signed-off-by: rtkevin <kevin@rtvision.com>
Signed-off-by: rtkevin <kevin@rtvision.com>
| functionCode += `value = obj[${i}]` | ||
| const tmpRes = buildValue(context, itemsLocation.getPropertyLocation(i), 'value') | ||
| const tmpRes = buildValue(context, itemLocation, 'value') |
There was a problem hiding this comment.
Shouldn't buildValue itself will resolve $ref?
There was a problem hiding this comment.
Maybe, I only looked into the code enough to fix the problem with minimal changes. But my problem wasn't with buildValue, it was that buildArrayTypeCondition was given item.type which was undefined since item was still {$ref }.
There was a problem hiding this comment.
I only changed the buildValue line to use the itemLocation I defined above so that it wouldn't need to do the itemsLocation.getPropertyLocation(i) a second time.
|
@climba03003 @ivan-tymoshenko |
Need to resolveRef here else buildArrayTypeCondition is given undefined item.type and returns undefined, which is falsy so throws the Item at i does not match schema definition error.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
added test that fails in current master and does not fail in patch.