Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: direct access to serialize method #751

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cesco69
Copy link
Contributor

@cesco69 cesco69 commented Dec 11, 2024

Direct access to serialize method (eg.: asString(key)) instead of access to object/method (eg.: serializer.asString(key))

Maybe faster...?

Side note: I can't run benchmark/test in local... If try to create a new branch and/or run test I see this error: t.plan is not a function

  duration_ms: 0.2367
  location: 'D:\\fast-json-stringify\\test\\additionalProperties.test.js:112:1'
  failureType: 'testCodeFailure'
  error: 't.plan is not a function'
  code: 'ERR_TEST_FAILURE'
  name: 'TypeError'
  stack: |-
    TestContext.<anonymous> (D:\fast-json-stringify\test\additionalProperties.test.js:113:5)
    Test.runInAsyncScope (node:async_hooks:203:9)
    Test.run (node:internal/test_runner/test:631:25)
    Test.processPendingSubtests (node:internal/test_runner/test:374:18)
    Test.postRun (node:internal/test_runner/test:715:19)
    Test.run (node:internal/test_runner/test:673:12)
    async Test.processPendingSubtests (node:internal/test_runner/test:374:7)

Please add benchmark TAG

Signed-off-by: francesco <francesco.bagnoli.69@gmail.com>
@cesco69 cesco69 marked this pull request as draft December 11, 2024 10:48
Signed-off-by: francesco <francesco.bagnoli.69@gmail.com>
Signed-off-by: francesco <francesco.bagnoli.69@gmail.com>
@cesco69 cesco69 marked this pull request as ready for review December 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant