Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(ci): use standardized template #29

Merged
merged 2 commits into from
Mar 10, 2021
Merged

style(ci): use standardized template #29

merged 2 commits into from
Mar 10, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Mar 9, 2021

Checklist

mcollina
mcollina requested changes Mar 9, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Mar 9, 2021

It seems that coveralls is configured by not working.

mcollina
mcollina requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because coveralls is not setup correctly or something.

@Fdawgs
Copy link
Member Author

Fdawgs commented Mar 9, 2021

CI is failing because coveralls is not setup correctly or something.

It looks okay and is using the same config as the main Fastify repo and other Fastify plugin repos.
I think it may be related to what you raised in fastify/fastify-accepts-serializer#37 (comment)

mcollina
mcollina requested changes Mar 9, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

mcollina commented Mar 9, 2021

CI is failing because coveralls is not setup correctly or something.

It looks okay and is using the same config as the main Fastify repo and other Fastify plugin repos.

I think it may be related to what you raised in fastify/fastify-accepts-serializer#37 (comment)

It's likely related. Enabling coveralls or analog for all repos requires significant work, so better avoid it entirely.

@mcollina
Copy link
Member

mcollina commented Mar 9, 2021

The main Fastify repo is a special/ snowflake case.

@Fdawgs Fdawgs changed the title ci: add parallel test coverage calculation style(ci): use standardized template Mar 9, 2021
@Fdawgs Fdawgs requested a review from mcollina March 10, 2021 12:26
mcollina
mcollina approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7bf2485 into fastify:master Mar 10, 2021
@Fdawgs Fdawgs deleted the ci/workflows branch March 10, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @mcollina