feat: add header option (#47) #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test for this as well https://github.com/fastify/fastify-basic-auth/blob/master/index.test-d.ts? |
mattyod
force-pushed
the
add-header-option-47
branch
from
1d11227
to
52f9434
Compare
|
Added an optional header to one of the existing tests, does that cover us? |
Eomm
reviewed
Jul 13, 2021
| ```js | ||
| fastify.register(require('fastify-basic-auth'), { | ||
| validate, | ||
| header: 'x-forwarded-authorization' |
There was a problem hiding this comment.
could we mention that it must be lowercase or add a lowercase function?
There was a problem hiding this comment.
Otherwise the lookup of the header will fail.
There was a problem hiding this comment.
I've added the .toLowerCase() suggestion from @mcollina. Will update the test to reflect this.
There was a problem hiding this comment.
Updated the test to demonstrate the to lowercasing. Not sure it needs a whole test of it's own but let me know if that's not enough.
mcollina
requested changes
Jul 13, 2021
mattyod
force-pushed
the
add-header-option-47
branch
from
0ab3580
to
0b4f90c
Compare
jsumners
approved these changes
Jul 13, 2021
Allow for a 'header' property to be specified in the options object.
If present use the value specified as the name of the header from
which to extract credentials for validation.
mattyod
force-pushed
the
add-header-option-47
branch
from
0b4f90c
to
4303901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct