-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastify generate <dir> --esm --lang=ts
doesn't generate esm enabled ts project
#577
Closed
2 tasks done
Labels
Comments
I don't think we have template for esm and ts at the same time. Would you like to contribute one? |
Thanks @mcollina for following up so promptly. Unfortunately, I don't have time to contribute this at the moment. I hope someone else can take this. |
Hey, just a heads up. I am having a look at this, will create a PR soon. |
Thanks! |
Thanks @S-Abhishek |
S-Abhishek
added a commit
to S-Abhishek/fastify-cli
that referenced
this issue
Jan 26, 2023
This commit will be amended with better implementation soon.
S-Abhishek
added a commit
to S-Abhishek/fastify-cli
that referenced
this issue
Jan 29, 2023
This commit will be amended with better implementation soon.
S-Abhishek
added a commit
to S-Abhishek/fastify-cli
that referenced
this issue
Mar 12, 2023
This commit will be amended with better implementation soon.
S-Abhishek
added a commit
to S-Abhishek/fastify-cli
that referenced
this issue
Mar 18, 2023
--esm --lang=ts support, and fixes code coverage of app-esm using c8
S-Abhishek
added a commit
to S-Abhishek/fastify-cli
that referenced
this issue
Mar 25, 2023
--esm --lang=ts support, and fixes code coverage of app-esm using c8
mcollina
pushed a commit
that referenced
this issue
May 3, 2023
Done in #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Fastify version
4.0.0
Plugin version
No response
Node.js version
18.12
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
13.1
Description
fastify generate
doesn't seem to work well when multiple options are provided.fastify generate . --esm
&fastify generate . --lang=ts
both seem to work well. But, combining optionsfastify generate . --esm --lang=ts
doesn't seem to create esm support in the generated ts project.Steps to Reproduce
Expected Behavior
The expected behavior is to generate an esm enabled typescript project
The text was updated successfully, but these errors were encountered: