Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use dot notation #634

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: use dot notation #634

merged 1 commit into from
Jun 29, 2023

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Jun 20, 2023 •
edited
Loading

Fixed lint error.

$ npm run lint

> fastify-cli@5.7.1 lint
> standard

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /Users/is2ei/src/github.com/is2ei/fastify-cli/test/generate-esm.test.js:36:36: ["c8"] is better written in dot notation. (dot-notation)
  /Users/is2ei/src/github.com/is2ei/fastify-cli/test/generate-esm.test.js:36:67: ["c8"] is better written in dot notation. (dot-notation)

Checklist

@is2ei
Copy link
Contributor Author

is2ei commented Jun 21, 2023 •
edited
Loading

The test has been failed since previous commits.
https://github.com/fastify/fastify-cli/actions/runs/5323279586/jobs/9649431388?pr=634

The test that is fired by previous commit:
https://github.com/fastify/fastify-cli/actions/runs/4869067221/jobs/8683150011

This PR focuses on fixing the lint error.

@is2ei
Copy link
Contributor Author

is2ei commented Jun 23, 2023

Could anyone review this?

mcollina
mcollina approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing :(

@is2ei
Copy link
Contributor Author

is2ei commented Jun 29, 2023 •
edited
Loading

@mcollina

Thanks for your comment! The failure is not caused by this change.
Lint and test failures occur in master branch.
This PR focuses on fixing the lint error.

@mcollina mcollina merged commit 24c5937 into fastify:master Jun 29, 2023
renovate bot referenced this pull request in specfy/specfy Aug 13, 2023
@renovate
chore(deps): update dependency fastify-cli to v5.8.0 (#142)
2977d8c 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify-cli](https://github.com/fastify/fastify-cli) | [`5.7.1` ->
`5.8.0`](https://renovatebot.com/diffs/npm/fastify-cli/5.7.1/5.8.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify-cli/5.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify-cli/5.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify-cli/5.7.1/5.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify-cli/5.7.1/5.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cli (fastify-cli)</summary>

###
[`v5.8.0`](https://github.com/fastify/fastify-cli/releases/tag/v5.8.0)

[Compare
Source](https://github.com/fastify/fastify-cli/compare/v5.7.1...v5.8.0)

##### What's Changed

- fix: Correct wrong instructions for typescript ejecting by
[@&#8203;anyonecancode](https://github.com/anyonecancode) in
[https://github.com/fastify/fastify-cli/pull/589](https://github.com/fastify/fastify-cli/pull/589)
- Improve the Typescript template. by
[@&#8203;meotimdihia](https://github.com/meotimdihia) in
[https://github.com/fastify/fastify-cli/pull/592](https://github.com/fastify/fastify-cli/pull/592)
- chore(.gitignore): add bun lockfile by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cli/pull/594](https://github.com/fastify/fastify-cli/pull/594)
- feat: add support for typescript and esm generation
([#&#8203;577](https://github.com/fastify/fastify-cli/issues/577)) by
[@&#8203;S-Abhishek](https://github.com/S-Abhishek) in
[https://github.com/fastify/fastify-cli/pull/585](https://github.com/fastify/fastify-cli/pull/585)
- fix: use dot notation by [@&#8203;is2ei](https://github.com/is2ei)
in
[https://github.com/fastify/fastify-cli/pull/634](https://github.com/fastify/fastify-cli/pull/634)
- Fix failing tests with cross-env by
[@&#8203;bcomnes](https://github.com/bcomnes) in
[https://github.com/fastify/fastify-cli/pull/639](https://github.com/fastify/fastify-cli/pull/639)
- print-routes options and print-plugins by
[@&#8203;bcomnes](https://github.com/bcomnes) in
[https://github.com/fastify/fastify-cli/pull/637](https://github.com/fastify/fastify-cli/pull/637)
- chore(deps): bump pino-pretty from 9.4.1 to 10.1.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/645](https://github.com/fastify/fastify-cli/pull/645)
- chore(deps-dev): bump
[@&#8203;types/node](https://github.com/types/node) from 18.17.0 to
20.4.4 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/646](https://github.com/fastify/fastify-cli/pull/646)
- fix error on undefined plugin by
[@&#8203;dancastillo](https://github.com/dancastillo) in
[https://github.com/fastify/fastify-cli/pull/649](https://github.com/fastify/fastify-cli/pull/649)

##### New Contributors

- [@&#8203;anyonecancode](https://github.com/anyonecancode) made their
first contribution in
[https://github.com/fastify/fastify-cli/pull/589](https://github.com/fastify/fastify-cli/pull/589)
- [@&#8203;S-Abhishek](https://github.com/S-Abhishek) made their first
contribution in
[https://github.com/fastify/fastify-cli/pull/585](https://github.com/fastify/fastify-cli/pull/585)
- [@&#8203;is2ei](https://github.com/is2ei) made their first
contribution in
[https://github.com/fastify/fastify-cli/pull/634](https://github.com/fastify/fastify-cli/pull/634)
- [@&#8203;dancastillo](https://github.com/dancastillo) made their
first contribution in
[https://github.com/fastify/fastify-cli/pull/649](https://github.com/fastify/fastify-cli/pull/649)

**Full Changelog**:
fastify/fastify-cli@v5.7.1...v5.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on
monday,every weekend" in timezone Europe/Paris, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Summonshr Summonshr mentioned this pull request Jun 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@is2ei @mcollina