add support for trustProxy option #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? We either need to stop using |
|
@mcollina last time I'll poke this thread, I just need to decide if we migrate out and write our own |
|
I'll land this tomorrow |
|
@mcollina any plans on releasing this? |
|
apparently, linting and typescript are failing (sorry for notnhaving spotted this sooner). Can you fix those? Maybe even rebase on top of main. |
|
No problem. I just pushed the fixes for that. |
|
CI is not green, I think the fix for that just landed. Can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
trustProxyoption. Since that option can take many different forms I added 3 new arguments based on the conversation I saw on a similar PR that was closed.#654
Checklist
npm run testandnpm run benchmarkand the Code of conduct