Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate test build function configured with skipOverride #784

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

jean-michelet
Copy link
Contributor

@jean-michelet jean-michelet commented Dec 15, 2024

I think that users expect to have access decorators defined globally in their tests.
Currently we generate the test application without wrapping it in fastify-plugin which causes confusions (c.f. here, here and here).

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit bdfd5ed into fastify:master Dec 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants