New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for response that does not set a cookie #247

Merged

mcollina merged 1 commit into master from fix-cors

Aug 2, 2023

Member

mcollina commented Aug 2, 2023 •

edited

Loading

Fixes #246

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
commit message and code follows the Developer's Certification of Origin
and the Code of conduct


          Fix support for response that does not set a cookie

b35946d

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina requested a review from Uzlopak

August 2, 2023 13:40

mcollina merged commit fbed571 into master

mcollina deleted the fix-cors branch

August 2, 2023 13:45

Uzlopak reviewed

View reviewed changes

Contributor

Uzlopak left a comment

I approve it, even though it was already merged.

bodinsamuel referenced this pull request in specfy/specfy


          fix(deps): update dependency @fastify/cookie to v9 (#113)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cookie](https://github.com/fastify/fastify-cookie) |
[`8.3.0` ->
`9.0.4`](https://renovatebot.com/diffs/npm/@fastify%2fcookie/8.3.0/9.0.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcookie/9.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcookie/9.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcookie/8.3.0/9.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcookie/8.3.0/9.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cookie (@&#8203;fastify/cookie)</summary>

###
[`v9.0.4`](https://github.com/fastify/fastify-cookie/releases/tag/v9.0.4)

[Compare
Source](https://github.com/fastify/fastify-cookie/compare/v9.0.3...v9.0.4)

#### What's Changed

- Fix support for response that does not set a cookie by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/fastify/fastify-cookie/pull/247](https://github.com/fastify/fastify-cookie/pull/247)

**Full Changelog**:
fastify/fastify-cookie@v9.0.3...v9.0.4

###
[`v9.0.3`](https://github.com/fastify/fastify-cookie/releases/tag/v9.0.3)

[Compare
Source](https://github.com/fastify/fastify-cookie/compare/v9.0.2...v9.0.3)

#### What's Changed

- Do not crash if responding from a previously-registered onRequest hook
by [@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/fastify/fastify-cookie/pull/245](https://github.com/fastify/fastify-cookie/pull/245)

**Full Changelog**:
fastify/fastify-cookie@v9.0.2...v9.0.3

###
[`v9.0.2`](https://github.com/fastify/fastify-cookie/releases/tag/v9.0.2)

[Compare
Source](https://github.com/fastify/fastify-cookie/compare/v9.0.1...v9.0.2)

#### What's Changed

- use for loop instead of for...of by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-cookie/pull/239](https://github.com/fastify/fastify-cookie/pull/239)
- Check if onSend ran and keep resetting the map by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-cookie/pull/242](https://github.com/fastify/fastify-cookie/pull/242)
- perf: only clear map when it's populated by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-cookie/pull/243](https://github.com/fastify/fastify-cookie/pull/243)
- perf: only call removeHeader when needed by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-cookie/pull/244](https://github.com/fastify/fastify-cookie/pull/244)

**Full Changelog**:
fastify/fastify-cookie@v9.0.1...v9.0.2

###
[`v9.0.1`](https://github.com/fastify/fastify-cookie/releases/tag/v9.0.1)

[Compare
Source](https://github.com/fastify/fastify-cookie/compare/v9.0.0...v9.0.1)

#### What's Changed

- Fix [@&#8203;fastify/session](https://github.com/fastify/session) by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/fastify/fastify-cookie/pull/240](https://github.com/fastify/fastify-cookie/pull/240)

**Full Changelog**:
fastify/fastify-cookie@v9.0.0...v9.0.1

###
[`v9.0.0`](https://github.com/fastify/fastify-cookie/releases/tag/v9.0.0)

[Compare
Source](https://github.com/fastify/fastify-cookie/compare/v8.3.0...v9.0.0)

#### What's Changed

- fix(docs): msecs to seconds
([#&#8203;219](https://github.com/fastify/fastify-cookie/issues/219))
by [@&#8203;seia-soto](https://github.com/seia-soto) in
[https://github.com/fastify/fastify-cookie/pull/220](https://github.com/fastify/fastify-cookie/pull/220)
- chore(deps-dev): bump sinon from 14.0.2 to 15.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/222](https://github.com/fastify/fastify-cookie/pull/222)
- chore(deps-dev): bump tsd from 0.24.1 to 0.25.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/223](https://github.com/fastify/fastify-cookie/pull/223)
- chore(.gitignore): add clinic by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cookie/pull/226](https://github.com/fastify/fastify-cookie/pull/226)
- chore(.gitignore): add bun lockfile by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cookie/pull/228](https://github.com/fastify/fastify-cookie/pull/228)
- chore(deps-dev): bump tsd from 0.25.0 to 0.26.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/229](https://github.com/fastify/fastify-cookie/pull/229)
- chore(deps-dev): bump tsd from 0.26.1 to 0.27.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/230](https://github.com/fastify/fastify-cookie/pull/230)
- chore(deps-dev): bump tsd from 0.27.0 to 0.28.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/231](https://github.com/fastify/fastify-cookie/pull/231)
- ci: only trigger on pushes to main branches by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cookie/pull/232](https://github.com/fastify/fastify-cookie/pull/232)
- chore(deps-dev): bump
[@&#8203;types/node](https://github.com/types/node) from 18.16.5 to
20.1.0 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cookie/pull/233](https://github.com/fastify/fastify-cookie/pull/233)
- Fix typo from 'node' to 'none' in CookieSerializeOptions for sameSite
attribute by [@&#8203;Mihai-MCW](https://github.com/Mihai-MCW) in
[https://github.com/fastify/fastify-cookie/pull/236](https://github.com/fastify/fastify-cookie/pull/236)
- Don't send the `Set-Cookie` header multiple times for the same cookie
by [@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-cookie/pull/237](https://github.com/fastify/fastify-cookie/pull/237)

#### New Contributors

- [@&#8203;seia-soto](https://github.com/seia-soto) made their first
contribution in
[https://github.com/fastify/fastify-cookie/pull/220](https://github.com/fastify/fastify-cookie/pull/220)
- [@&#8203;Mihai-MCW](https://github.com/Mihai-MCW) made their first
contribution in
[https://github.com/fastify/fastify-cookie/pull/236](https://github.com/fastify/fastify-cookie/pull/236)
- [@&#8203;gurgunday](https://github.com/gurgunday) made their first
contribution in
[https://github.com/fastify/fastify-cookie/pull/237](https://github.com/fastify/fastify-cookie/pull/237)

**Full Changelog**:
fastify/fastify-cookie@v8.3.0...v9.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on
monday,every weekend" in timezone Europe/Paris, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet