Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastifyCookieClearCookie sets maxAge to zero #304

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

aristofun
Copy link
Contributor

@aristofun aristofun commented Oct 9, 2024

Improves devX/compatibility for some users of the library and some cookie jar implementations.

Closes #303

Checklist

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking to check something

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@fastify/cookie",
"version": "10.0.1",
"version": "10.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. we'll bump this ourselves.

@gurgunday gurgunday mentioned this pull request Oct 9, 2024
4 tasks
plugin.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 321932f into fastify:master Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clearCookie does not include maxAge, neither allows to pass it as options
3 participants