Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bring into line with reusable workflow #79

Merged
merged 7 commits into from
May 24, 2022
Merged

ci: bring into line with reusable workflow #79

merged 7 commits into from
May 24, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 24, 2022

Not able to use the reusable workflow in this repo due to use of a service container that can only be used with Linux containers, and the reusable workflow runs Linux, macOS, and Windows.

So instead this PR brings all the features from the reusable workflow to the repo.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@Fdawgs
Copy link
Member Author

Fdawgs commented May 24, 2022

Error is: fastify-plugin: @fastify/elasticsearch - expected '^4.0.0' fastify version, '4.0.0-rc.3' is installed.

@mcollina going to change the version to 4.x or else it will continue to struggle with rc versions.

fastify: '^4.0.0',

@Fdawgs
Copy link
Member Author

Fdawgs commented May 24, 2022

Requires #80 to fix the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants