-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate test suite from tap
to node:test
#190
Merged
simoneb
merged 5 commits into
fastify:master
from
narendra-reddy-nf:nearform/migrate-to-node-test
Sep 11, 2024
Merged
chore: migrate test suite from tap
to node:test
#190
simoneb
merged 5 commits into
fastify:master
from
narendra-reddy-nf:nearform/migrate-to-node-test
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendra-reddy-nf
changed the title
Nearform/migrate to node test
Miigrate Sep 9, 2024
tap
to node:test
narendra-reddy-nf
changed the title
Miigrate
migrate test suite from Sep 9, 2024
tap
to node:test
tap
to node:test
mcollina
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node 20 and 22 have t.plan
https://nodejs.org/api/test.html#contextplancount
Uzlopak
changed the title
migrate test suite from
chore: migrate test suite from Sep 9, 2024
tap
to node:test
tap
to node:test
simoneb
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR replaces tap with node:test and introduces c8 for code coverage.
npm run test
andnpm run benchmark
and the Code of conduct