Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test not merge #199

Closed
wants to merge 3 commits into from
Closed

chore: test not merge #199

wants to merge 3 commits into from

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 18, 2022 •
edited
Loading

test #196

Notes:

  • after the first commit the CI has not been triggered
  • opened the draft PR and the CI should run
  • commit to the branch should trigger the CI
  • marked the PR as ready and the CI should not run
  • commit to the branch should trigger the CI

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 18, 2022

This change has to land asap... :P

@Eomm Eomm marked this pull request as ready for review August 18, 2022 17:08
@Eomm Eomm closed this Aug 18, 2022
@Eomm Eomm deleted the Eomm-patch-1 branch August 18, 2022 17:12
@Eomm
Copy link
Member Author

Eomm commented Aug 18, 2022

@Fdawgs works!

@Fdawgs
Copy link
Member

Fdawgs commented Aug 19, 2022

Forgot about draft PRs.

We could also stop the CI from running on draft PRs, and only trigger when they're marked as ready to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eomm @Uzlopak @Fdawgs