Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript type for sandbox csp directive #63

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Fix typescript type for sandbox csp directive #63

merged 1 commit into from
Oct 19, 2019

Conversation

JGiola
Copy link
Contributor

@JGiola JGiola commented Oct 16, 2019

Hi, this PR will close #54 adding the value true to the sandbox csp directive to its allowed values.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

SerayaEryn
SerayaEryn approved these changes Oct 17, 2019
View reviewed changes
Copy link

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit e11f465 into fastify:master Oct 19, 2019
@JGiola JGiola deleted the fix/sandbox-ts-type branch October 20, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerayaEryn SerayaEryn SerayaEryn approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sandbox: true
3 participants
@JGiola @mcollina @SerayaEryn