Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable license checking #581

Merged
merged 2 commits into from
Aug 3, 2022
Merged

ci: enable license checking #581

merged 2 commits into from
Aug 3, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 2, 2022

See fastify/workflows#49

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

@mcollina

Found CC-BY-4.0 licensed package

@mcollina
Copy link
Member

mcollina commented Aug 2, 2022

what package?

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

@mcollina

Package "caniuse-lite@1.0.30001299" is licensed under "CC-BY-4.0" which is not permitted by the --onlyAllow flag. Exiting.

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 2, 2022

next itself depends on that directly.

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

I really dont know how we can handle this and be on the safe side. I kind of cant imagine to add CC-BY-4.0 to the licensechecker allowed list.

@mcollina
Copy link
Member

mcollina commented Aug 2, 2022

we should add a parameter to the action

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

Like

license-checker: true
license-checker-allowed: MIT;ISC

?

@mcollina
Copy link
Member

mcollina commented Aug 2, 2022

Yes

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 3, 2022

@Fdawgs

Ok?

@Fdawgs Fdawgs merged commit 98ba62a into master Aug 3, 2022
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch August 3, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants