Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use generic on userinfo #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: use generic on userinfo #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,13 @@ declare namespace fastifyOauth2 {

revokeAllToken(revokeToken: Token, httpOptions: Object | undefined): Promise<void>;

userinfo(tokenSetOrToken: Token | string): Promise<Object>;
userinfo<TUserInfo>(tokenSetOrToken: Token | string): Promise<TUserInfo>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we set the default?

Suggested change
userinfo<TUserInfo>(tokenSetOrToken: Token | string): Promise<TUserInfo>;
userinfo<TUserInfo = Object>(tokenSetOrToken: Token | string): Promise<TUserInfo>;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so? the generic already serves as a default value


userinfo(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined): Promise<Object>;
userinfo<TUserInfo>(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined): Promise<TUserInfo>;

userinfo(tokenSetOrToken: Token | string, callback: (err: any, userinfo: Object) => void): void;
userinfo<TUserInfo>(tokenSetOrToken: Token | string, callback: (err: any, userinfo: TUserInfo) => void): void;

userinfo(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined, callback: (err: any, userinfo: Object) => void): void;
userinfo<TUserInfo>(tokenSetOrToken: Token | string, userInfoExtraOptions: UserInfoExtraOptions | undefined, callback: (err: any, userinfo: TUserInfo) => void): void;
}
export type UserInfoExtraOptions = { method?: 'GET' | 'POST', via?: 'header' | 'body', params?: object };
export const fastifyOauth2: FastifyOauth2
Expand Down