Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap out ms for @lukeed/ms #312

Merged
merged 2 commits into from
Jul 28, 2023
Merged

swap out ms for @lukeed/ms #312

merged 2 commits into from
Jul 28, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jul 28, 2023

The old ms is being replaced with this one in most fastify plugins

Reference: fastify/fastify-sensible#132

TLDR: it's faster

Checklist

@gurgunday
Copy link
Member Author

Not related, but having trouble understanding this coverage report, these uncovered lines are literally covered?

# time=10834.974ms
--------------------------|---------|----------|---------|---------|-------------------
File                      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
--------------------------|---------|----------|---------|---------|-------------------
All files                 |   98.44 |    96.26 |     100 |     100 |                   
 fastify-rate-limit       |     100 |    98.24 |     100 |     100 |                   
  index.js                |     100 |    98.24 |     100 |     100 | 159-167           

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f2c3d4a into fastify:master Jul 28, 2023
7 checks passed
@gurgunday gurgunday deleted the ms branch July 28, 2023 08:47
@mcollina
Copy link
Member

Those lines do not look like to be covered in the sense that the "else" of the if is never exerciesed

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 28, 2023

If you run the test locally than if the lines are red, it means uncovere lines. Like a if clause not met.
If it is yellow it means uncovered branch like var1 || var2, where var1 is covered but var2 not.

@gurgunday
Copy link
Member Author

Today I learned 😁

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants