-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package): explicitly declare js module type #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
approved these changes
Oct 27, 2023
This was referenced Oct 27, 2023
This was referenced Oct 27, 2023
To be honest I don't think this will ever happen, as it would break existing applications. I would find it more likely that from a major version onwards, it will default it to module instead of cjs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 21.1.0 added a flag to detect module types, which will probably become default in the future. Declaring the type will cause Node to skip detection on startup, reducing startup time.
Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling anyway, and the main fastify repo already does it.
Will update the rest of the repos and point to this PR in their PRs.
Checklist
and the Code of conduct