revert: handle ban in store #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
added a commit
that referenced
this pull request
Jul 10, 2024
* Updating for v5 (#338) * ci: add node 21 to test matrix and remove node 14 and 16 * package.json update for v5 * merge main to next (#348) * Update README.md to reflect #307 (#342) * Redis should work with ban (#336) * Redis should work with ban * fix ttl * simplify * format * remove warning * move property * add test * fix test * fix test * fix test * still fix the same test * make it non-breaking * make it non-breaking * make it non-breaking * make it non-breaking * perf: add ban back * Bumped v8.1.0 Signed-off-by: Matteo Collina <hello@matteocollina.com> * Bumped v9.0.0 Signed-off-by: Matteo Collina <hello@matteocollina.com> * Fix in-memory cache bug when there is only one entry (#345) * Bumped v9.0.1 --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Trevor Lund <89029310+tlund101@users.noreply.github.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Igor Savin <iselwin@gmail.com> * Revert "merge main to next (#348)" This reverts commit 5446122. * revert workflow update as its causing issues (#350) * revert: handle ban in store (#347) * remove ban handling from store * don't use negation * add undef * don't pass ban to promis * fix accidental explicit checks * fix accidental line change * inline ban * Workflow v4 (#354) * refactor: make RedisStore default key a default parameter (#356) * refactor redis parameters and throw if no instance was provided * revert error * Add function support for timeWindow (#357) * feat: dynamic time window support * fix: proper usage of timeWindowString --------- Co-authored-by: lukas <git@lukaselsner.de> * update docs (#360) * fix: remove unnecessary parameter timeWindow (#363) * refactor: consistent option handling (#365) * small refactor in option handling * simplify * simplify * perf: pregenerate `timeWindow` string when possible and use `noop` as default function (#364) * pregenerate timeWindowString if possible * simplify * simplify * noop * simplify * simple-example * rename * update for v5 (#370) * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update for v5 * update fastify deps --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Eliphaz Bouye <53824344+Eliphaz-Bouye@users.noreply.github.com> Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com> Co-authored-by: Trevor Lund <89029310+tlund101@users.noreply.github.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Igor Savin <iselwin@gmail.com> Co-authored-by: lukas <mindrunner@users.noreply.github.com> Co-authored-by: lukas <git@lukaselsner.de> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
The change that moved ban handling to the store-side in a non-breaking manner hasn't accomplished anything meaningful in terms of fixing the sync issue between multiple deployments when an in-memory counter is used, I basically misunderstood the problem
Naturally there will always be this issue with in-memory counters, and moving the ban calculation to the store just increased the network payload for Redis configurations, albeit a little bit
Now, I'm pretty sure not many people have custom stores that handle
banthemselves, because the change is pretty new (a month old), but in any case, I will be targeting next to be sure