-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to Fastify v4, dropped error handler #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
71 tasks
Fdawgs
reviewed
May 11, 2022
Fdawgs
approved these changes
May 12, 2022
May I ask for the details of dropping the custom error handler? The motivation was:
|
@mcollina details? |
Check out fastify/fastify#3261 |
wd-David
pushed a commit
to wd-David/fastify-esbuild
that referenced
this pull request
Jul 7, 2022
…ify/sensible registration (#14) Compatibilty with Fastify v4 fastify/fastify-sensible#109
lamweili
added a commit
to lamweili/fastify-sensible
that referenced
this pull request
Jul 31, 2024
…fy#18 Signed-off-by: Lam Wei Li <lam_wei_li@hotmail.com>
4 tasks
mcollina
pushed a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Collina hello@matteocollina.com
This PR updates to Fastify v4 and drops the custom error handler support.
I do not think that's needed with Fastify v4 by default as that's now way simpler to manage.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct