-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export HttpError type #159
Export HttpError type #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test?
https://github.com/fastify/fastify-sensible/blob/master/types/index.test-d.ts
@gurgunday Sure, added! Let me know if you want me to add more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/sensible](https://togithub.com/fastify/fastify-sensible) | [`^5.5.0` -> `^5.6.0`](https://renovatebot.com/diffs/npm/@fastify%2fsensible/5.6.0/5.6.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fsensible/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fsensible/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fsensible/5.6.0/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fsensible/5.6.0/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@fastify/sensible](https://togithub.com/fastify/fastify-sensible) | [`^5.5.0` -> `^5.6.0`](https://renovatebot.com/diffs/npm/@fastify%2fsensible/5.5.0/5.6.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fsensible/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fsensible/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fsensible/5.5.0/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fsensible/5.5.0/5.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>fastify/fastify-sensible (@​fastify/sensible)</summary> ### [`v5.6.0`](https://togithub.com/fastify/fastify-sensible/releases/tag/v5.6.0) [Compare Source](https://togithub.com/fastify/fastify-sensible/compare/v5.5.0...v5.6.0) #### What's Changed - chore(package): explicitly declare js module type by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-sensible/pull/149](https://togithub.com/fastify/fastify-sensible/pull/149) - Update README.md by [@​r-a-f-a](https://togithub.com/r-a-f-a) in [https://github.com/fastify/fastify-sensible/pull/150](https://togithub.com/fastify/fastify-sensible/pull/150) - build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-sensible/pull/151](https://togithub.com/fastify/fastify-sensible/pull/151) - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-sensible/pull/153](https://togithub.com/fastify/fastify-sensible/pull/153) - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-sensible/pull/158](https://togithub.com/fastify/fastify-sensible/pull/158) - Export HttpError type by [@​MoSheikh](https://togithub.com/MoSheikh) in [https://github.com/fastify/fastify-sensible/pull/159](https://togithub.com/fastify/fastify-sensible/pull/159) #### New Contributors - [@​r-a-f-a](https://togithub.com/r-a-f-a) made their first contribution in [https://github.com/fastify/fastify-sensible/pull/150](https://togithub.com/fastify/fastify-sensible/pull/150) - [@​MoSheikh](https://togithub.com/MoSheikh) made their first contribution in [https://github.com/fastify/fastify-sensible/pull/159](https://togithub.com/fastify/fastify-sensible/pull/159) **Full Changelog**: fastify/fastify-sensible@v5.5.0...v5.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6W119-->
Rexports the HttpError type to fix errors when attempting to use the
httpError
reexport from@fastify/sensible
.Checklist
npm run test
andnpm run benchmark
and the Code of conduct