Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types/node to devDependencies #31

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Move @types/node to devDependencies #31

merged 1 commit into from
Sep 17, 2020

Conversation

sergejostir
Copy link
Contributor

@sergejostir sergejostir commented Sep 17, 2020 •
edited
Loading

Checklist

@types/node should be only a dev dependency since it is not needed for the runtime at all.

@sergejostir sergejostir mentioned this pull request Sep 17, 2020
Closed
mcollina
mcollina approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a67dbe9 into fastify:master Sep 17, 2020
@sergejostir sergejostir deleted the patch-1 branch September 24, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergejostir @mcollina