Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: automerge only for prs #41

Merged
merged 1 commit into from
Nov 11, 2020
Merged

chore: automerge only for prs #41

merged 1 commit into from
Nov 11, 2020

Conversation

salmanm
Copy link
Member

@salmanm salmanm commented Nov 11, 2020

  • Added a check in automerge job to make sure it only runs for PRs not for commits (to avoid the error Unhandled error: TypeError: Cannot read property 'number' of undefined)
  • Extracted automerge script into a separate file

Checklist

mcollina
mcollina approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4c6d73a into fastify:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salmanm @mcollina