Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing createError type definition #50

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix: add missing createError type definition #50

merged 1 commit into from
Mar 15, 2021

Conversation

gkampitakis
Copy link
Contributor

Hey 👋, found the type definition createError missing. I checked the types from http-errors and used them.

Checklist

mcollina
mcollina approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b9b252a into fastify:master Mar 15, 2021
@gkampitakis gkampitakis deleted the missing-types branch March 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkampitakis @mcollina