Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage to 100%. Closes #56 #72

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

0xvbetsun
Copy link
Contributor

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I've left a few notes.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.taprc Outdated Show resolved Hide resolved
lib/vary.js Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
lib/vary.js Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/httpErrorsReply.test.js Outdated Show resolved Hide resolved
test/httpErrorsReply.test.js Show resolved Hide resolved
test/httpErrorsReply.test.js Show resolved Hide resolved
test/httpErrorsReply.test.js Outdated Show resolved Hide resolved
@Eomm Eomm merged commit 3a2ae09 into fastify:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants