Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant parameter #395

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Remove redundant parameter #395

merged 4 commits into from
Jul 31, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jul 30, 2023 •
edited
Loading

There is no need to pass the Fastify instance to setUpHeadAndGet as it already has access to it

This makes me wonder, for consistency purposes, why not put all the Fastify related functions inside the plugin function to avoid the need to pass fastify

Checklist

Eomm
Eomm reviewed Jul 31, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak reviewed Jul 31, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
Uzlopak
Uzlopak approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit ebfc5b0 into fastify:master Jul 31, 2023
15 checks passed
@gurgunday gurgunday deleted the refactor branch July 31, 2023 20:43
thedavidprice added a commit to redwoodjs/redwood that referenced this pull request Sep 8, 2023
@renovate @thedavidprice
fix(deps): update dependency @fastify/static to v6.11.0 (#9129)
0cc790a 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://togithub.com/fastify/fastify-static) |
[`6.10.2` ->
`6.11.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.11.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.10.2/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.10.2/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v6.11.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.10.2...v6.11.0)

##### What's Changed

- Update README with 404+wildcard behavior by
[@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in
[fastify/fastify-static#390
- add tests for
[#&#8203;234](https://togithub.com/fastify/fastify-static/issues/234) by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#391
- remove linting from the test script by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#394
- Remove redundant parameter by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#395
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 2.34.0 to 6.2.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-static#397
- add url type by [@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#398

##### New Contributors

- [@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) made
their first contribution in
[fastify/fastify-static#390
- [@&#8203;gurgunday](https://togithub.com/gurgunday) made their first
contribution in
[fastify/fastify-static#391

**Full Changelog**:
fastify/fastify-static@v6.10.2...v6.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Sep 13, 2023
@renovate @thedavidprice @jtoar
fix(deps): update dependency @fastify/static to v6.11.0 (#9129)
a97c600 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://togithub.com/fastify/fastify-static) |
[`6.10.2` ->
`6.11.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.11.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.10.2/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.10.2/6.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v6.11.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.10.2...v6.11.0)

##### What's Changed

- Update README with 404+wildcard behavior by
[@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in
[fastify/fastify-static#390
- add tests for
[#&#8203;234](https://togithub.com/fastify/fastify-static/issues/234) by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#391
- remove linting from the test script by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#394
- Remove redundant parameter by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#395
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 2.34.0 to 6.2.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-static#397
- add url type by [@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#398

##### New Contributors

- [@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) made
their first contribution in
[fastify/fastify-static#390
- [@&#8203;gurgunday](https://togithub.com/gurgunday) made their first
contribution in
[fastify/fastify-static#391

**Full Changelog**:
fastify/fastify-static@v6.10.2...v6.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
renovate bot added a commit to specfy/specfy that referenced this pull request Dec 4, 2023
@renovate
fix(deps): update dependency @fastify/static to v6.12.0 (#393)
dbb8a5c 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://togithub.com/fastify/fastify-static) |
[`6.10.2` ->
`6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v6.12.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.12.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.11.2...v6.12.0)

#### What's Changed

- fix eslint by [@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#415
- refactor: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#418
- refactor: remove unused bindings by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#417
- perf(index): check set size over converting to array to check length
by [@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#416
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#419
- test: replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#420

**Full Changelog**:
fastify/fastify-static@v6.11.2...v6.12.0

###
[`v6.11.2`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.2)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.11.1...v6.11.2)

#### What's Changed

- fix: allow fallback to fastify@2.22 route config by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify-static#410

**Full Changelog**:
fastify/fastify-static@v6.11.1...v6.11.2

###
[`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1)

#### What's Changed

- Remove test/content-type/sample.jpg.br by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify-static#400
- build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-static#401
- added some small code improvements by
[@&#8203;turnerran](https://togithub.com/turnerran) in
[fastify/fastify-static#399
- (more) small performance/clarity improvements by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#405
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#407
- use native stream by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#408
- Fix request route config deprecation warnings by
[@&#8203;TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in
[fastify/fastify-static#409

#### New Contributors

- [@&#8203;turnerran](https://togithub.com/turnerran) made their first
contribution in
[fastify/fastify-static#399
- [@&#8203;TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their
first contribution in
[fastify/fastify-static#409

**Full Changelog**:
fastify/fastify-static@v6.11.0...v6.11.1

###
[`v6.11.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.10.2...v6.11.0)

#### What's Changed

- Update README with 404+wildcard behavior by
[@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in
[fastify/fastify-static#390
- add tests for
[#&#8203;234](https://togithub.com/fastify/fastify-static/issues/234) by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#391
- remove linting from the test script by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#394
- Remove redundant parameter by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#395
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 2.34.0 to 6.2.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-static#397
- add url type by [@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#398

#### New Contributors

- [@&#8203;Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) made
their first contribution in
[fastify/fastify-static#390
- [@&#8203;gurgunday](https://togithub.com/gurgunday) made their first
contribution in
[fastify/fastify-static#391

**Full Changelog**:
fastify/fastify-static@v6.10.2...v6.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurgunday @mcollina @Uzlopak @Eomm