chore!: bump dependency send@3 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climba03003
commented
Jul 12, 2024
| @@ -471,7 +471,7 @@ t.test('dir list json format - extended info', t => { | |||
| t.equal(response.statusCode, 200) | |||
| const bodyObject = JSON.parse(body.toString()) | |||
| t.equal(bodyObject.dirs[0].name, 'empty') | |||
| t.equal(typeof bodyObject.dirs[0].stats.atime, 'string') | |||
| t.equal(typeof bodyObject.dirs[0].stats.atimeMs, 'number') | |||
There was a problem hiding this comment.
I believe there is bug on Node.js side, JSON.stringify do not print atime directly.
|
Can you update the actions too? We don't support Node v18 anymore. |
|
Depends on fastify/fastify-compress#300 |
|
Coverage |
jsumners
added a commit
that referenced
this pull request
Jul 12, 2024
* feat: preparation for fastify@5 (#444) * Update for v5 * c8 ignore * remove dep * c8 --------- Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> * update fastify deps * chore!: bump dependency send@3 (#455) * chore!: bump dependency send@3 * fixup * fixup * chore: use v5 workflow * chore: bump dependency send@3.1.0 * fixup * update plugin config * fix deprecation warning --------- Co-authored-by: Mohammed Bilal Shareef <bilalshareef.h@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the current test fail is due to @fastify/compress
https://github.com/fastify/fastify-compress/blob/14b83fe235000ed2620d2387b02f84b4170f55fa/index.js#L568-L573
Depends on fastify/send#80
We should wait until the next release of both
@fastify/sendand@fastify/compress.Checklist
npm run testandnpm run benchmarkand the Code of conduct