[backbport v4.x] fix: html urls should not be absolute #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidTanner looks like CI is failing for |
|
@dancastillo when was the last time the build passed for this branch? I saw other PRs that were merged with the same failures. I can check tomorrow |
|
Good callout, looks like this has been failing for a while now https://github.com/fastify/fastify-swagger-ui/commits/v4.x/ |
|
@dancastillo can you make a PR removing the package manager ci? |
|
Oh never mind it's a backport |
gurgunday
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
When the HTML uses an absolute URL,
/documentation/index.css, then the browser requests the data from the/. This is an issue if swagger is set up as a nested route. I added a test for this where swagger is registered as a child of another prefix route.Fixed #176
Related to #164, #162