-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (ci): migrate ci to fastify plugins reusable workflows #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request Test Coverage Report for Build 1736512411
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1736512411Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we migrate this repo to the new centalized worfflow?
It would be cool to:
- add the "1 lint runs" on the main flow https://github.com/fastify/workflows/
- reference the flow here (example: chore: testing new reusable workflow fastify-autoload#216 )
@Eomm > sure I will take a look to do so. I will create a linter "standalone" workflow so that we should be able to use it like this : name: ci
on:
push:
paths-ignore:
- 'docs/**'
- '*.md'
pull_request:
paths-ignore:
- 'docs/**'
- '*.md'
jobs:
linter:
uses: fastify/workflows/.github/workflows/linter-ci.yml@v2
test:
needs: linter
uses: fastify/workflows/.github/workflows/plugins-ci.yml@v2 |
On hold. |
Hello.
This PR aims to :
tap
(enforcing 100% code coverage)Checklist
npm run test
andnpm run benchmark
and the Code of conduct