Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (ci): migrate ci to fastify plugins reusable workflows #531

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Jan 23, 2022

Hello.

This PR aims to :

  • add some npm scripts (improves DX and CI task splitting)
  • run CI linter only once
  • migrate to fastify plugins reusable workflow
  • remove coveralls and check coverage with tap (enforcing 100% code coverage)

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1736512411

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1722904549: 0.0%
Covered Lines: 636
Relevant Lines: 636

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 23, 2022

Pull Request Test Coverage Report for Build 1736512411

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1722904549: 0.0%
Covered Lines: 636
Relevant Lines: 636

💛 - Coveralls

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we migrate this repo to the new centalized worfflow?

It would be cool to:

@darkgl0w
Copy link
Member Author

@Eomm > sure I will take a look to do so.

I will create a linter "standalone" workflow so that we should be able to use it like this :

name: ci

on:
  push:
    paths-ignore:
      - 'docs/**'
      - '*.md'
  pull_request:
    paths-ignore:
      - 'docs/**'
      - '*.md'

jobs:
  linter:
    uses: fastify/workflows/.github/workflows/linter-ci.yml@v2

  test:
    needs: linter
    uses: fastify/workflows/.github/workflows/plugins-ci.yml@v2

@darkgl0w
Copy link
Member Author

On hold.
I will wait for reviews and suggestions on fastify/workflows#10 to see how this PR should progress.

@darkgl0w darkgl0w marked this pull request as ready for review January 26, 2022 20:27
@darkgl0w darkgl0w changed the title chore (ci): update OS matrix and run linter only once chore (ci): migrate ci to fastify plugins reusable workflows Jan 26, 2022
@Eomm Eomm merged commit 568c60d into fastify:master Jan 27, 2022
@darkgl0w darkgl0w deleted the update-ci branch January 27, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants