Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable license checking #644

Merged
merged 2 commits into from
Aug 3, 2022
Merged

ci: enable license checking #644

merged 2 commits into from
Aug 3, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 2, 2022

See fastify/workflows#49

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022 •
edited
Loading

@Fdawgs
@mcollina

package "argparse@2.0.1" is licensed under "Python-2.0" which is not permitted by the --onlyAllow flag. Exiting.

@mcollina
Copy link
Member

mcollina commented Aug 2, 2022

where are we using this?

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

@mcollina

js-yaml

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 2, 2022

May be worth replacing js-yaml with another package?

@mcollina
Copy link
Member

mcollina commented Aug 2, 2022

We should switch to https://www.npmjs.com/package/yaml instead.

@Uzlopak Uzlopak mentioned this pull request Aug 3, 2022
Merged
4 tasks
@Uzlopak Uzlopak merged commit 991113e into master Aug 3, 2022
@Uzlopak Uzlopak deleted the Fdawgs-patch-1 branch August 3, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @Uzlopak @mcollina