-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose FromSchema options #22
Conversation
Just wanted to make the same thing. Please, merge this. This is game changer, if you want to use Date throughout the code, and serialize/deserialize it to/from string. I've already tried your code and it works. |
Just came to +1 this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an unit test on how the new option should behave?
And assert the correct output when you use it.
Didn't realize I was working off the main branch for this, sync'ed up with this repo and added docs and tests for specifically #25 as that was what my use case was also. |
Thanks! |
Any plans on doing a release soon? Would definitely prefer to track the main package again instead of my fork. EditNow release, thanks! |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
There are not a lot of tests/documentation for this package or any benchmarks so not sure if the second and third checkboxes are relevant. If deemed needed I can look at doing something
Otherwise my goal with this PR is to be able to pass in shared references that we define. They are supported by the provider as described in their documentation here. All I need was the ability to pass through my references, which accomplished by adding the generic.