Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci #59

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix ci #59

merged 1 commit into from
Oct 8, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 8, 2023

Checklist

Eomm
Eomm reviewed Oct 8, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [12, 14, 16, 17]
node-version: [12, 14, 16, 18, 20]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12?! 😱

Let's make it breaking 😎

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. wait

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 8, 2023

@Eomm PTAL

@Uzlopak Uzlopak merged commit a8c4820 into main Oct 8, 2023
17 checks passed
@Uzlopak Uzlopak deleted the fix-ci branch October 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@gurgunday gurgunday gurgunday approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Uzlopak @Eomm @Fdawgs @gurgunday