Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port parsing #148

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix port parsing #148

merged 1 commit into from
Jul 13, 2024

Conversation

gurgunday
Copy link
Member

No description provided.

@gurgunday gurgunday requested review from jsumners and zekth July 13, 2024 18:54
jsumners
jsumners approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jsumners jsumners merged commit 9f96b77 into fastify:next Jul 13, 2024
14 checks passed
@gurgunday gurgunday deleted the fix branch July 13, 2024 19:09
jsumners added a commit that referenced this pull request Jul 15, 2024
@jsumners @gurgunday
Merge next into master (#147)
f69b584 
* update for v5 (#140)

* update for v5 (#140)

* update fastify deps

* Fix port parsing (#148)

---------

Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@zekth zekth Awaiting requested review from zekth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgunday @jsumners