Update for Fastify v5 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, will start merging now, but just for consistency, I've so far kept the .taprc files and haven't moved tap options to package.json as so far we've preferred explicit config files So it would be great if you could keep https://github.com/fastify/fastify-cookie/blob/next/.taprc |
gurgunday
approved these changes
Apr 15, 2024
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
|
CI is failing |
|
Hey @synapse sorry for this, but master had a breaking change and it requires some refactoring, do you have time to take a look? |
gurgunday
approved these changes
May 10, 2024
mcollina
pushed a commit
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct