Update onClose Hook docs #1995
Closed
Update onClose Hook docs #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://medium.com/@fastifyjs/8275d613fba4 the new bumped up version of avvio (v 6.0.0) removes the instance from the onClose hook as the first parameter.
|
Sorry I got confused in medium article. |
delvedor
requested changes
Dec 20, 2019
There was a problem hiding this comment.
This is not entirely correct, if you take a look at fastify/avvio#76, the supported function signatures are:
fastify.addHook('onClose', () => {})
fastify.addHook('onClose', (done) => {})
fastify.addHook('onClose', (instance, done) => {})
|
Yeah i noticed that so closed the PR
…On Fri, 20 Dec, 2019, 5:16 PM Tomas Della Vedova, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is not entirely correct, if you take a look at fastify/avvio#76
<fastify/avvio#76>, the supported function
signatures are:
fastify.addHook('onClose', () => {})
fastify.addHook('onClose', (done) => {})
fastify.addHook('onClose', (instance, done) => {})
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1995?email_source=notifications&email_token=AFTAFNAMMIPS2FMIWDAQ4QLQZSWCTA5CNFSM4J54WT6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP5PIXQ#pullrequestreview-335213662>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFTAFNGUW3FP7J34C7RBIVDQZSWCTANCNFSM4J54WT6A>
.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://medium.com/@fastifyjs/8275d613fba4 the new bumped up version of avvio (v 6.0.0) removes the instance from the onClose hook as the first parameter.