You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched existing issues to ensure the bug has not already been reported
Fastify version
x
Plugin version
x
Node.js version
16
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
Ubuntu 21.04
Description
a valid value like: "repository": "github:nearform/mercurius-apollo-tracing",
causes error like this:
TypeError: Cannot destructure property 'owner' of 'parseGitUrl(...)' as it is null.
at github (/home/capaj/.nvm/versions/node/v16.7.0/lib/node_modules/releasify/lib/github.js:7:11)
at module.exports (/home/capaj/.nvm/versions/node/v16.7.0/lib/node_modules/releasify/lib/commands/draft.js:63:18)
at async module.exports (/home/capaj/.nvm/versions/node/v16.7.0/lib/node_modules/releasify/lib/commands/publish.js:106:21)
at async Command.func (/home/capaj/.nvm/versions/node/v16.7.0/lib/node_modules/releasify/lib/cli.js:18:7)
Steps to Reproduce
use "repository": "github:nearform/mercurius-apollo-tracing",
Expected Behavior
no type error is thrown for plain string value in repository
The text was updated successfully, but these errors were encountered:
oh yeah, the problem is not in parse-github-url.
Problem is releasify always assumes that the repository value in pkg.json is an object. It can be just a plain string.
I will rephrase the issue.
capaj
changed the title
repository is not parsed correctly when it is not a URL
Type error is thrown, when repository in package.json is a string, not an object
Sep 24, 2021
Prerequisites
Fastify version
x
Plugin version
x
Node.js version
16
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
Ubuntu 21.04
Description
a valid value like:
"repository": "github:nearform/mercurius-apollo-tracing",
causes error like this:
Steps to Reproduce
use
"repository": "github:nearform/mercurius-apollo-tracing",
Expected Behavior
no type error is thrown for plain string value in
repository
The text was updated successfully, but these errors were encountered: