Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support both types of "repository" in package.json #187

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Sep 24, 2021

add support for package.json which has "repository" as string, not an object

Checklist

lib/commands/getRepositoryUrl.js Outdated Show resolved Hide resolved
@Eomm
Copy link
Member

Eomm commented Sep 29, 2021

The CI is reporting a regression on coverage, I think the error test on getRepositoryUrl is missing

ERROR: Coverage for lines (99.69%) does not meet global threshold (100%)
ERROR: Coverage for branches (94.93%) does not meet global threshold (95%)
ERROR: Coverage for statements (99.7%) does not meet global threshold (100%)

@capaj
Copy link
Contributor Author

capaj commented Sep 29, 2021

Yeah I will add it.

@capaj capaj force-pushed the fix-repository-url-TypeError branch from 1760853 to 80cd649 Compare September 29, 2021 08:53
@capaj capaj requested a review from Eomm September 29, 2021 09:13
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm Eomm merged commit 1e54d33 into fastify:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error is thrown, when repository in package.json is a string, not an object
3 participants