Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump simple-git from 2.48.0 to 3.0.3" #246

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 6, 2022

Reverts #211

causes:

➜  any-schema-you-like git:(master) releasify publish -n -s major -m
  simple-git:scheduler Constructed, concurrency=5 +0ms
  simple-git:task:status:1 Adding task to the queue, commands = [ 'status', '--porcelain', '-b', '-u', '--null' ] +0ms
(node:1550) [PINODEP008] PinoWarning: prettyPrint is deprecated, look at https://github.com/pinojs/pino-pretty for alternatives.
(Use `node --trace-warnings ...` to show where the warning was created)
  simple-git:scheduler Scheduling id=1 +2ms
  simple-git:scheduler Attempting id=1 +0ms
  simple-git:task:status:1 Starting task +1ms
  simple-git [GitExecutor] [SPAWN] git [ 'status', '--porcelain', '-b', '-u', '--null' ] +0ms
  simple-git:task:status:1 [SPAWN] git [ 'status', '--porcelain', '-b', '-u', '--null' ] +0ms
  simple-git:task:status:1 [SPAWN] {
  simple-git:task:status:1   cwd: '/Users/mspigolon/workspace/any-schema-you-like',
  simple-git:task:status:1   env: undefined,
  simple-git:task:status:1   windowsHide: true
  simple-git:task:status:1 } +0ms
  simple-git:task:status:1 [SPAWN] stdOut received 26 bytes +15ms
  simple-git:output:status:1 [stdOut] ## master...origin/master +0ms
  simple-git:task:status:1 [HANDLE] Preparing to handle process response exitCode=0 stdOut= +1ms
  simple-git [GitExecutor] [HANDLE] retrieving task output complete +16ms
  simple-git:task:status:1 [HANDLE] retrieving task output complete +0ms
  simple-git:task:status:1 passing response to task's parser as a utf-8 +0ms
  simple-git:scheduler Completing id= 1 +16ms
  simple-git:scheduler Schedule attempt ignored, pending=0 running=0 concurrency=5 +0ms
[] ERROR: Cannot read properties of undefined (reading 'length')
    err: {
      "type": "TypeError",
      "message": "Cannot read properties of undefined (reading 'length')",
      "stack":
          TypeError: Cannot read properties of undefined (reading 'length')
              at /Users/mspigolon/.nvm/versions/node/v18.6.0/lib/node_modules/releasify/lib/commands/publish.js:213:12
              at Array.reduce (<anonymous>)
              at inlineNotEmpty (/Users/mspigolon/.nvm/versions/node/v18.6.0/lib/node_modules/releasify/lib/commands/publish.js:210:28)
              at module.exports (/Users/mspigolon/.nvm/versions/node/v18.6.0/lib/node_modules/releasify/lib/commands/publish.js:82:43)
              at async Command.func (/Users/mspigolon/.nvm/versions/node/v18.6.0/lib/node_modules/releasify/lib/cli.js:18:7)
    }

Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be excluded in the CI workflow, by using the auto-merge-exclude option, to stop dependabot from opening and merging a PR again.

See https://github.com/fastify/workflows#inputs

@Eomm
Copy link
Member Author

Eomm commented Aug 11, 2022

@Fdawgs how can I disable this check?

image

We can ignore this vuln for now since this is a cli

The best solution will be to remove the dep, but the actual version is just broken

@Fdawgs
Copy link
Member

Fdawgs commented Aug 11, 2022

@Fdawgs how can I disable this check?

Not able to skip this check in the shared workflow atm. You can just ignore this though. :)

@Eomm Eomm merged commit 3e6e16a into master Aug 11, 2022
@Eomm Eomm deleted the revert-211-dependabot/npm_and_yarn/simple-git-3.0.3 branch August 11, 2022 07:08
Eomm added a commit that referenced this pull request Aug 13, 2022
* Revert "build(deps): bump simple-git from 2.48.0 to 3.0.3 (#211)"

This reverts commit 54974e9.

* ci: no simple-git update
@Uzlopak Uzlopak mentioned this pull request Dec 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants